Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/w 499 #398

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Wip/w 499 #398

merged 5 commits into from
Jan 19, 2024

Conversation

t-horikawa
Copy link
Contributor

@t-horikawa t-horikawa requested a review from ashigeru December 28, 2023 08:40
ashigeru
ashigeru requested changes Jan 10, 2024
View reviewed changes
...ommon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/ClientInformation.java Outdated Show resolved Hide resolved
...ommon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/ClientInformation.java Show resolved Hide resolved
...ommon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/ClientInformation.java Outdated Show resolved Hide resolved
...ommon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/ClientInformation.java Outdated Show resolved Hide resolved
...ommon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/ClientInformation.java Outdated Show resolved Hide resolved
modules/ipc/src/test/java/com/tsurugidb/tsubakuro/channel/ipc/sql/ServerWireImpl.java Outdated Show resolved Hide resolved
modules/proto/src/main/protos/tateyama/proto/endpoint/request.proto Outdated Show resolved Hide resolved
modules/proto/src/main/protos/tateyama/proto/endpoint/request.proto Outdated Show resolved Hide resolved
modules/proto/src/main/protos/tateyama/proto/endpoint/request.proto Outdated Show resolved Hide resolved
modules/session/src/main/java/com/tsurugidb/tsubakuro/common/SessionBuilder.java Outdated Show resolved Hide resolved
ashigeru
ashigeru requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ashigeru ashigeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

残件と合わせて確認お願いします。

modules/proto/src/main/protos/tateyama/proto/endpoint/request.proto Outdated Show resolved Hide resolved
modules/session/src/main/java/com/tsurugidb/tsubakuro/common/SessionBuilder.java Outdated Show resolved Hide resolved
ashigeru
ashigeru approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ashigeru ashigeru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数点マイナーな修正だけ入れてもらって、あとはOKです。

...ommon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/ClientInformation.java Show resolved Hide resolved
...mmon/src/main/java/com/tsurugidb/tsubakuro/channel/common/connection/wire/impl/WireImpl.java Show resolved Hide resolved
modules/ipc/src/main/java/com/tsurugidb/tsubakuro/channel/ipc/connection/IpcConnectorImpl.java Outdated Show resolved Hide resolved
@t-horikawa t-horikawa merged commit b433500 into master Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashigeru ashigeru ashigeru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-horikawa @ashigeru