Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Рейтинг преподавателей #6

Merged
merged 12 commits into from
Oct 17, 2024
Merged

Рейтинг преподавателей #6

merged 12 commits into from
Oct 17, 2024

Conversation

Temmmmmo
Copy link
Member

Изменения

Описано тут

Детали реализации

Тоже можно почитать тут

Check-List

  • Вы проверили свой код перед отправкой запроса? -- в полчетвертого утра уже как-то не до проверок
  • Вы написали тесты к реализованным функциям? -- ага может еще четыре сервиса написать?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End? ну это не забыл)

p.s. кто вообще придумал писать описания к ПРам???

@Temmmmmo Temmmmmo linked an issue Oct 17, 2024 that may be closed by this pull request
Бэк рейтинга преподов #1
Closed
@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py23387%35–36, 44
rating_api/routes
   comment.py662858%37, 43–46, 94–115, 132–135, 149
   exc_handlers.py17288%26, 33
   lecturer.py883165%55, 104–143, 157, 165, 183, 189
rating_api/schemas
   base.py12467%6–9
TOTAL3037276% 

Summary

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 0.894s ⏱️

DaymasS
DaymasS reviewed Oct 17, 2024
View reviewed changes
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/lecturer.py Outdated Show resolved Hide resolved
rating_api/routes/lecturer.py Show resolved Hide resolved
rating_api/routes/lecturer.py Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/lecturer.py Outdated Show resolved Hide resolved
DaymasS
DaymasS reviewed Oct 17, 2024
View reviewed changes
models/db.py Show resolved Hide resolved
DaymasS
DaymasS reviewed Oct 17, 2024
View reviewed changes
migrations/env.py Outdated Show resolved Hide resolved
parfenovma
parfenovma approved these changes Oct 17, 2024
View reviewed changes
migrations/versions/dbe6ca79a40d_init.py Outdated Show resolved Hide resolved
models/db.py Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/lecturer.py Show resolved Hide resolved
@parfenovma
Copy link
Contributor

тестов бы ещё напилить)

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

1 similar comment
@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@Temmmmmo
Copy link
Member Author

тестов бы ещё напилить)

сделано

@Temmmmmo Temmmmmo merged commit 7264339 into main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaymasS DaymasS DaymasS left review comments

@parfenovma parfenovma parfenovma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Бэк рейтинга преподов
3 participants
@Temmmmmo @parfenovma @DaymasS