Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added create_ts and update_ts to create_comment #50

Merged
merged 25 commits into from
Nov 24, 2024
Merged

added create_ts and update_ts to create_comment #50

merged 25 commits into from
Nov 24, 2024

Conversation

zipperman1
Copy link
Contributor

@zipperman1 zipperman1 commented Nov 15, 2024 •
edited
Loading

Изменения

добавлена возможность указать время создания и изменения комментария для админов

Детали реализации

проверка на скоуп rating.comment.review
заменяем None на utcnow если дата на указана
скипаем проверку времени если у автора есть скоуп

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2024 •
edited
Loading

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
rating_api
   __main__.py440%1–7
   exceptions.py26292%35–36
rating_api/models
   base.py55198%76
   db.py73297%61, 74
rating_api/routes
   comment.py731284%31, 42–45, 108, 118–123, 130, 153, 169
   exc_handlers.py20195%26
   lecturer.py841483%132–153, 169, 177, 195, 201
rating_api/schemas
   base.py12467%6–9
TOTAL4544091% 

Summary

Tests Skipped Failures Errors Time
44 0 💤 3 ❌ 0 🔥 3.048s ⏱️

Zimovchik
Zimovchik requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@Zimovchik Zimovchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо потестить локально + дописать тесты

rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
@zipperman1 zipperman1 linked an issue Nov 16, 2024 that may be closed by this pull request
Выгрузка данных из дубинушки #21
Closed
@zipperman1 zipperman1 self-assigned this Nov 16, 2024
@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@zipperman1 zipperman1 requested a review from Zimovchik November 16, 2024 19:58
Zimovchik
Zimovchik requested changes Nov 17, 2024
View reviewed changes
rating_api/routes/comment.py Outdated Show resolved Hide resolved
@zipperman1 zipperman1 requested a review from Zimovchik November 17, 2024 15:25
@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

Zimovchik
Zimovchik requested changes Nov 18, 2024
View reviewed changes
rating_api/routes/comment.py Outdated Show resolved Hide resolved
tests/test_routes/test_comment.py Show resolved Hide resolved
Temmmmmo
Temmmmmo reviewed Nov 22, 2024
View reviewed changes
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
Temmmmmo
Temmmmmo reviewed Nov 24, 2024
View reviewed changes
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
rating_api/routes/comment.py Outdated Show resolved Hide resolved
@zipperman1 zipperman1 requested a review from Temmmmmo November 24, 2024 14:42
@Zimovchik
Copy link
Member

резолвни конфликты

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@github-actions GitHub Actions
Copy link

💩 Code linting failed, use black and isort to fix it.

@Temmmmmo Temmmmmo merged commit a82a2bb into main Nov 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Temmmmmo Temmmmmo Temmmmmo left review comments

@Zimovchik Zimovchik Zimovchik approved these changes

Assignees

@zipperman1 zipperman1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Выгрузка данных из дубинушки
3 participants
@zipperman1 @Zimovchik @Temmmmmo