Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

CONTRIBUTING.md #9

Open
choujar opened this issue Nov 1, 2018 · 2 comments
Open

CONTRIBUTING.md #9

choujar opened this issue Nov 1, 2018 · 2 comments

Comments

@choujar
Copy link

choujar commented Nov 1, 2018

Hi @mrchrisadams,

I'm going to be helping out with the project and have spoken to Gavin about some small increments to begin with. Do you have a "Contributing" guide?

I wanna cause as little disruption here as possible.

Thanks!

@mrchrisadams
Copy link
Member

Hi @choujar, I'm afraid not - I've struggled to work out what the process should look like, and find time to work on it myself, let alone write one for others - I've typically done an onboarding over a shared screen-sharing call.

I won't be able to get any some guidelines together before this week.

It might be easier to run through these together on a call, as I've been trying to follow a few conventions, like:

  • formatting code with prettier for consistency
  • writing tests for new features, with jest
  • following the Vue JS style guide for naming and creating components

Can you tell me what timezone you're in? A call might make this easier, and the stuff we cover I can capture and put into a CONTRIBUTING.md.

Otherwise PRs gratefully accepted.

@choujar
Copy link
Author

choujar commented Nov 19, 2018

Hi @mrchrisadams,

Sorry, I've been a bit incapacitated due to my laptop being repaired. But I'm back on the grid now.
I'm in UTC +10.5 (yes, that half is a thing).

Also, while we are in the process of setting up a call, any chance you can remove the following file from the main repository?

.firebaserc - since we might all be running a different project name

I would like to submit a PR, but I don't want to conflict with your project name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants