Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields for images not saving in frontend editing if inside a repeater matrix #2025

Closed
Laksone opened this issue Jan 15, 2025 · 2 comments

Comments

@Laksone
Copy link

Laksone commented Jan 15, 2025

Short description of the issue

Seems like i discovered a bug, where editing custom fields for images are not saving in frontend editing if the image field is inside a repeater matrix. It's also not saving the value when editing the repeater item itself in backend (which obviously is the reason why it's not working in frontend either).
The default description field works fine, aswell as editing and saving the page that uses the field.

Code in frontend:

{% for repeaterItem in page.images_test_repeater_matrix %}
    {% for image in repeaterItem.images_test %}
        <img src="{{ image.url }}">
    {% endfor %}

    <edit page="{{ repeaterItem.id }}" field="images_test">
        <button class="btn btn-primary">
            EDIT
        </button>
    </edit>
{% endfor %}

Videos that demonstrate the issue:

1.mp4
2.mp4

Steps to reproduce the issue

  1. Add text field
  2. Add image field (with custom fields activated and the above text field added)
  3. Add repeater matrix (with image field above)
  4. Add template and page with repeater matrix field and upload some images
  5. Find the image gallery repeater item under Admin->Repeaters->... try to edit the custom text field and save
  • ProcessWire version: 3.0.244
  • (Optional) PHP version: 8.3
  • (Optional) MySQL version: 8
@ryancramerdesign
Copy link
Member

Thanks @Laksone I've pushed a fix for this issue. Can you check if it also corrects it there? Thanks.

@Laksone
Copy link
Author

Laksone commented Feb 21, 2025

Great, it's fixed! Thanks! 👍

@Laksone Laksone closed this as completed Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants