Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape Mapper #46

Closed
1 task done
alexdmiller opened this issue Jan 13, 2025 · 11 comments · Fixed by #58
Closed
1 task done

Shape Mapper #46

alexdmiller opened this issue Jan 13, 2025 · 11 comments · Fixed by #58

Comments

@alexdmiller
Copy link

alexdmiller commented Jan 13, 2025

Properties File URL

https://github.com/alexdmiller/shape-mapper/releases/latest/download/shapemapper.txt

Home Page URL

https://shapemapper.dev

Guidelines Confirmation

  • I confirm
Copy link

There was an error in reading your properties file or parsing it.

Please ensure that the URL is correct and the file follows the required format.

Errors when parsing file. Please check all required fields, and file format.

Copy link

github-actions bot commented Jan 13, 2025

Your properties file was successfully parsed.
A pull request with your contribution has been successfully created.

@github-actions github-actions bot linked a pull request Jan 13, 2025 that will close this issue
Copy link

github-actions bot commented Jan 13, 2025

Your properties file was successfully parsed.
A pull request with your contribution has been successfully created.

@SableRaf
Copy link
Contributor

@Stefterv I thought we were asking for a link to the library.txt file, rather than the library.properties file, since the latter isn’t meant to be included in the release artifacts.

Shouldn't it be https://github.com/alexdmiller/shape-mapper/releases/download/v0.1.5/shapemapper.txt instead?

@Stefterv
Copy link
Collaborator

@mingness
Copy link
Collaborator

I see, the bottom of the issue says the library.properties file, which confuses the issue. I'll review the wording of the issues later today.

Copy link

github-actions bot commented Jan 13, 2025

Your properties file was successfully parsed.
A pull request with your contribution has been successfully created.

@mingness
Copy link
Collaborator

I've updated the url in the issue description to what @Stefterv said it should be. The download url in the database entry is now live.
@alexdmiller there is an inconsistency between the prettyVersion in the library.properties/shapemapper.txt file, which is 1.0.0, and the github release which is v0.1.5 - @Stefterv suggested an improvement to the workflow in the template that would use the release tag and assign it to the prettyVersion in the released *.txt, but that's not there yet - maybe in time for your update. :)
Could you make a patch to your library release, synchronizing the pretty versions? Thanks for working with us as we iron out kinks.

@alexdmiller
Copy link
Author

Thanks for helping figure it out! I just updated the prettyVersion to match the github release.

Copy link

github-actions bot commented Jan 15, 2025

Your properties file was successfully parsed.
A pull request with your contribution has been successfully created.

@Stefterv
Copy link
Collaborator

Screenshot 2025-01-15 at 08 11 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment