chore(eslint): add unicorn/prefer-dom-node-text-content rule
#2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
chore
|
🎊 PR Preview c07ade7 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2869.surge.sh 🕐 Build time: 0.013s
🤖 By surge-preview |
|
♻️ PR Preview faa5b4f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
force-pushed
the
2742-add_unicorn/prefer-dom-node-text-content_rule
branch
from
43c83e7 to
c07ade7
Compare
csouchet
force-pushed
the
2742-add_unicorn/prefer-dom-node-text-content_rule
branch
from
c07ade7 to
c0ece7a
Compare
csouchet
removed
the
depends on another PR ⚠️
csouchet
commented
Sep 21, 2023
tbouffard
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
✔️ Tested with the surge preview environment. https://process-analytics-bpmn-visualization-js-demo_preview-pr-2869.surge.sh/dev/public/: the version correctly displays in the footer
✔️ tested locally http://localhost:10001/dev/public/bpmn-rendering.html loading an invalid BPMN diagram
csouchet
deleted the
2742-add_unicorn/prefer-dom-node-text-content_rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid to have to many changes by enabling
plugin:unicorn/recommended, I choose to enable some rule one-by-one.https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-text-content.md
Part of #2824
Covers #2742