chore(eslint): add unicorn/prevent abbreviations rule
#2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
chore
|
♻️ PR Preview 9313b6f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 9313b6f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
requested changes
Sep 19, 2023
Comment on lines
+27
to
+28
| readonly sourceReferenceId?: string, | ||
| readonly targetReferenceId?: string, |
There was a problem hiding this comment.
thought: renaming these properties is valid, this in an internal class 😸
There was a problem hiding this comment.
thought: changes here are valid as these are internal classes
tbouffard
approved these changes
Sep 20, 2023
| // only the ctrl key | ||
| const isZoomWheelEvent = evt.ctrlKey && !evt.altKey && !evt.shiftKey && !evt.metaKey; | ||
| const isZoomWheelEvent = event.ctrlKey && !event.altKey && !event.shiftKey && !event.metaKey; |
csouchet
force-pushed
the
2742-add_unicorn/prevent-abbreviations_rule
branch
from
7884540 to
9313b6f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid to have to many changes by enabling
plugin:unicorn/recommended, I choose to enable some rule one-by-one.Part of #2824
Covers #2742