-
Notifications
You must be signed in to change notification settings - Fork 48
Issue #191: SplitImage basic unit tests #211
Conversation
Test to see if generateNewGlyph successfully adds glyph_cells and glyph_color to local storage, and that glyph_cells has 15 items.
Test if visiting the history page and clicking "Preview Message" works and brings up the modal dialog. Also test closing the dialog.
…tions into registration-page-update
…ts/privly-applications into registration-page-update Conflicts: Login/new.html.subtemplate
…ions into registration-page-update
…ions into d356-tooltiptest
…ions into d356-historytest
Issue #166 : Change Posting Prompts to be a Clearer Step by Step
Fixed 404 links in PlainPost docs.
Fix incorrect charset
updated tests,don't load complete page
@smcgregor I've not built the templates yet (as they were not built initially in this branch). Do let me know if I need to do that as well. |
// key to the absolute URL, which is not reliable on | ||
// continuous integration. | ||
beforeEach(function() { | ||
var keys = Object.keys(__html__); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't use this hack anymore. You must create the DOM elements you need to test inside the javascript.
Can you please address the comments I left? Also, this PR includes updating the branch from master. These should be two separate pull requests. |
…cations into hitesh96db-register
ZeroBin tests correction
Consistency among Icons
Modify equality operator to strict
Whoops! I did some mistake while rebasing the branch. I'll try to resolve this. Sorry! |
…ns into gsoc-SplitImage
I think I'll have to start over with my repository. This is getting too complicated. :-/ Thankfully, I always make a backup so work is not lost, yet. |
I've not added unit tests for checking keys in localStorage yet (as written in Messages tests). I've done so because keys are saved to localStorage in Messages but not in SplitImage. So do you want me to add the feature to save keys in localStorage? Tests for the same can be written then.