Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Issue #191: SplitImage basic unit tests #211

Closed
wants to merge 32 commits into from
Closed

Issue #191: SplitImage basic unit tests #211

wants to merge 32 commits into from

Conversation

vatsalj
Copy link
Contributor

@vatsalj vatsalj commented Mar 10, 2015

I've not added unit tests for checking keys in localStorage yet (as written in Messages tests). I've done so because keys are saved to localStorage in Messages but not in SplitImage. So do you want me to add the feature to save keys in localStorage? Tests for the same can be written then.

mikky-cecil and others added 25 commits March 4, 2015 16:21
Test to see if generateNewGlyph successfully adds glyph_cells and
glyph_color to local storage, and that glyph_cells has 15 items.
Test if visiting the history page and clicking "Preview Message" works
and brings up the modal dialog. Also test closing the dialog.
…ts/privly-applications into registration-page-update

Conflicts:
	Login/new.html.subtemplate
Issue #166 : Change Posting Prompts to be a Clearer Step by Step
Fixed 404 links in PlainPost docs.
updated tests,don't load complete page
@vatsalj
Copy link
Contributor Author

vatsalj commented Mar 10, 2015

@smcgregor I've not built the templates yet (as they were not built initially in this branch). Do let me know if I need to do that as well.

// key to the absolute URL, which is not reliable on
// continuous integration.
beforeEach(function() {
var keys = Object.keys(__html__);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use this hack anymore. You must create the DOM elements you need to test inside the javascript.

@smcgregor
Copy link
Member

Can you please address the comments I left? Also, this PR includes updating the branch from master. These should be two separate pull requests.

Modify equality operator to strict
@vatsalj
Copy link
Contributor Author

vatsalj commented Mar 10, 2015

Whoops! I did some mistake while rebasing the branch. I'll try to resolve this. Sorry!

@vatsalj
Copy link
Contributor Author

vatsalj commented Mar 10, 2015

I think I'll have to start over with my repository. This is getting too complicated. :-/ Thankfully, I always make a backup so work is not lost, yet.

@vatsalj vatsalj closed this Mar 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants