-
Notifications
You must be signed in to change notification settings - Fork 48
Updated SplitImage branch #198
Updated SplitImage branch #198
Conversation
Selenium Tests
With the new merge strategy I think this may be the last time I need to do this.
Updated the SJCL library from Stanford University to the latest version i.e. 1.0.2
Wrap an immediate function invocation in parens to improve code quality
Fix Code Climate issues in parameters.js
…oljagetia/privly-applications into anmoljagetia-update-SJCL-to-version-1.0.2
Oh, just had dinner with friends and it's late :-( |
They are duplicates. Do you see any advantage to working from your PR, or should I just look at the first one to climb the hill? |
Well, I just compared two branches.
Other differences are mainly caused by However I made a mistake here :-( my SplitImage branch is based on my previous work, which should not be included in this branch. I will fix it later. Currently my branch builds well and passes all tests :-) |
Thanks for the summary. It would be better to leave base64.js, rawdeflate.js, rawinflate.js, and zerobin.js in the Message directory for the time being. We have modified them, but they are not our libraries so they don't exactly fit in either the vendor or the shared directories. Let's just reference them across apps for the time being. This isn't good style, but I would like to evaluate the more recent options for JS compression before we adopt them as the recommended standard -- particularly for SplitImage. |
Closed for #201 Thanks for addressing the comments, but these became very difficult to review. |
Merged master branch to SplitImage branch. #189