ci: fix coveralls workflow step #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sripwoud
added
bug 🐛
sripwoud
commented
Jul 2, 2024
Comment on lines
+119
to
+120
| parallel: true | ||
| flag-name: run ${{ join(matrix.*, '-') }} |
There was a problem hiding this comment.
inputs usage described here
sripwoud
force-pushed
the
fix/coveralls
branch
4 times, most recently
from
125f5fa to
44e9d2e
Compare
|
captured new issue #22 |
Closed
0xjei
pushed a commit
that referenced
this pull request
Jul 3, 2024
Culprit was running the coveralls action in a separate job. Indeed, job contexts being isolated, the [coveralls context didn't have any coverage data](https://github.com/privacy-scaling-explorations/zk-kit.solidity/actions/runs/9762627031/job/26946626860#step:2:49). And the default behavior of the coveralls action is to report a failure in that case. The fix consists in running `coverallsapp/github-action` in parallel in the `tests` job. ## Note I am aware of the stuck test ci checks:  This is due to a GH action limitation: ci required checks defined in rulesets/branch protection rules are always required, no matter if the corresponding job was skipped or not. And our workflow does conditionally skip jobs... There seems to be some workarounds described [here](https://github.com/orgs/community/discussions/13690) that I will try later. In the meantime please ignore these stuck ci checks please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Culprit was running the coveralls action in a separate job. Indeed, job contexts being isolated, the coveralls context didn't have any coverage data. And the default behavior of the coveralls action is to report a failure in that case.
The fix consists in running
coverallsapp/github-actionin parallel in thetestsjob.Note
I am aware of the stuck test ci checks:
This is due to a GH action limitation: ci required checks defined in rulesets/branch protection rules are always required, no matter if the corresponding job was skipped or not. And our workflow does conditionally skip jobs...
There seems to be some workarounds described here that I will try later.
In the meantime please ignore these stuck ci checks please.