Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: fix coveralls workflow step (#21)
Culprit was running the coveralls action in a separate job. Indeed, job contexts being isolated, the [coveralls context didn't have any coverage data](https://github.com/privacy-scaling-explorations/zk-kit.solidity/actions/runs/9762627031/job/26946626860#step:2:49). And the default behavior of the coveralls action is to report a failure in that case. The fix consists in running `coverallsapp/github-action` in parallel in the `tests` job. ## Note I am aware of the stuck test ci checks: ![image](https://github.com/privacy-scaling-explorations/zk-kit.solidity/assets/38692952/9b441a2f-abd1-44ca-8219-f2db572f19d6) This is due to a GH action limitation: ci required checks defined in rulesets/branch protection rules are always required, no matter if the corresponding job was skipped or not. And our workflow does conditionally skip jobs... There seems to be some workarounds described [here](https://github.com/orgs/community/discussions/13690) that I will try later. In the meantime please ignore these stuck ci checks please.
- Loading branch information