Support for IMPLICIT_TIME_DEPENDENT equation types & Advection application
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've switched to a bool, but the performance seems to be about the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the partial implementation of implicit equations from a few years ago.
Right now, we store the old solution value for all implicit equation type fields with a
boost::unordered_map. This should allow for straightforward extension to higher order time schemes (by indexing previous time states).The performance is about the same, if not slightly worse, since we have to check whether we have a map entry that needs to be copied for each field index in
solveIncrement.cc. This can likely be circumvented by another bool entry to thevariable_infostruct.Closes #228