Deprecate use of sx prop by deprecating the SxProp type definition #5443
Conversation
🦋 Changeset detectedLatest commit: ca0f8d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
jonrohan
changed the title
|
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
jonrohan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
|
Thinking on this more, I think only the converted components are using |
|
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
jonrohan
changed the title
|
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355834 |
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: passing
|
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Closes https://github.com/github/primer/issues/4571
This pull deprecates the
SxProptype definition. This will inform anyone using thesxprop on these components that it is deprecated and should be CSS modules instead. The result is non-blocking but looks like this in the editor:Changelog
New
Depreacte use of sx prop by switching to a deprecated type definition
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist