Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #5370, #5349 due to visual regressions #5434

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Revert #5370, #5349 due to visual regressions #5434

merged 3 commits into from
Dec 13, 2024

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Dec 13, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bdfb1c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5434 December 13, 2024 13:36 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.21 KB (-0.31% 🔽)
packages/react/dist/browser.umd.js 103.55 KB (-0.27% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5434 December 13, 2024 13:47 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355040

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 13, 2024
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 13, 2024
@francinelucca francinelucca marked this pull request as ready for review December 13, 2024 14:42
@francinelucca francinelucca requested a review from a team as a code owner December 13, 2024 14:42
@francinelucca francinelucca changed the title Revert "refactor(FormControl): update to CSS Modules behind feature flag" Revert #5370, #5349 due to visual regressions Dec 13, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added status: review needed and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 13, 2024
@francinelucca francinelucca added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit da7debd Dec 13, 2024
46 checks passed
@francinelucca francinelucca deleted the revert-5370-refactor/update-form-control-to-css-modules-3 branch December 13, 2024 15:09
@primer primer bot mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJDev TylerJDev TylerJDev approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member status: review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francinelucca @TylerJDev