Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionList + ActionList.Divider) Convert to CSS Modules #5375

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Dec 6, 2024

Closes https://github.com/github/primer/issues/4468

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 8184666

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.91 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js 104.22 KB (+0.14% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354076

@jonrohan
Copy link
Member

jonrohan commented Dec 9, 2024

This seems good just want to double check integrations if there's any failures

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 9, 2024
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 9, 2024
@langermank langermank added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit ba0a6c0 Dec 9, 2024
42 checks passed
@langermank langermank deleted the al-divider-css branch December 9, 2024 22:15
@primer primer bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants