Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BaseStyles): Convert BaseStyles to CSS modules behind team feature flag #5361

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

JelloBagel
Copy link
Contributor

Closes https://github.com/github/primer/issues/4358

Changelog

Changed

  • Convert BaseStyles to CSS modules behind primer_react_css_modules_team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: d91d756

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.28 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 102.64 KB (-0.03% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353826

@JelloBagel JelloBagel marked this pull request as ready for review December 5, 2024 20:38
@JelloBagel JelloBagel requested a review from a team as a code owner December 5, 2024 20:38
@JelloBagel JelloBagel requested a review from mperrotti December 5, 2024 20:38
@JelloBagel
Copy link
Contributor Author

The dotcom integration test failures seem unrelated to this PR, citing similar test failure from a slack thread: https://github.slack.com/archives/C07QUP8G909/p1733413713531239

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 6, 2024
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dotcom and everything seems good.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5361 December 6, 2024 23:00 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
@jonrohan jonrohan enabled auto-merge December 6, 2024 23:01
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
@jonrohan jonrohan added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 2fbdd3b Dec 6, 2024
42 checks passed
@jonrohan jonrohan deleted the jellobagel-basestyles-css-modules branch December 6, 2024 23:17
@primer primer bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants