Update Banner.tsx #4598
Merged
Update Banner.tsx #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the use of --space tokens
🦋 Changeset detectedLatest commit: a39b256 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
joshblack
approved these changes
May 16, 2024
|
@lukasoppermann when you have a sec, could you add a changeset as a patch that talks about the changes to the CSS Custom Properties used? Thanks! |
|
@joshblack do we want a release for this? There is no change to the output. |
khiga8
pushed a commit
that referenced
this pull request
May 31, 2024
* Update Banner.tsx Remove the use of --space tokens * added changeset
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of --space tokens
Related to primer/primitives#956
Changelog
Replaced space token with equal base size token.
Rollout strategy
It should have no impact on the users.
Testing & Reviewing
Merge checklist