Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconButton with tooltip is incompatible with ButtonGroup #5452

Closed
iansan5653 opened this issue Dec 17, 2024 · 2 comments
Closed

IconButton with tooltip is incompatible with ButtonGroup #5452

iansan5653 opened this issue Dec 17, 2024 · 2 comments
Labels
react

Comments

@iansan5653
Copy link
Contributor

When IconButton renders tooltips, it inserts an additional element after the button. This in turn breaks ButtonGroup's use of the :last-child selector to set border-radii, causing an IconButton at the end of a ButtonGroup to have square corners:

Screenshot showing normal button and icon button inside a button group. The icon button's right-side corners are squared off even though it is the last item in the group
@langermank
Copy link
Contributor

Thanks! I think this is a duplicate and we have an open PR addressing this so going to close.

PR: #5123
Duplicate issue: #4129

@iansan5653
Copy link
Contributor Author

Awesome, thanks!

@iansan5653 iansan5653 mentioned this issue Dec 17, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iansan5653 @langermank