Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for size-fine and size-coarse output #963

Merged
merged 2 commits into from
May 31, 2024
Merged

fix for size-fine and size-coarse output #963

merged 2 commits into from
May 31, 2024

Conversation

lukasoppermann
Copy link
Contributor

No description provided.

@lukasoppermann lukasoppermann requested review from a team as code owners May 31, 2024 13:02
@lukasoppermann lukasoppermann requested a review from jonrohan May 31, 2024 13:02
Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: 57dd21c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 31, 2024

Design Token Diff

/css/functional/size/size-coarse.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/size/size-coarse.css	2024-05-31 13:05:31.440058073 +0000
@@ -0,0 +1,7 @@
+@media (pointer: coarse) {
+  :root {
+    --control-minTarget-auto: 2.75rem;
+    --controlStack-small-gap-auto: 1rem;
+    --controlStack-medium-gap-auto: 0.75rem;
+  }
+}

/css/functional/size/size-fine.css

+++ /home/runner/work/primitives/primitives/dist/css/functional/size/size-fine.css	2024-05-31 13:05:31.460057955 +0000
@@ -0,0 +1,7 @@
+@media (pointer: fine) {
+  :root {
+    --control-minTarget-auto: 1rem;
+    --controlStack-small-gap-auto: 0.5rem;
+    --controlStack-medium-gap-auto: 0.5rem;
+  }
+}

/css/primitives.css

+++ /home/runner/work/primitives/primitives/dist/css/primitives.css	2024-05-31 13:05:31.776056087 +0000
@@ -52,8 +52,20 @@
 --breakpoint-xlarge: 80rem;
 --breakpoint-xxlarge: 87.5rem;
}
-
-
+@media (pointer: coarse) {
+  :root {
+    --control-minTarget-auto: 2.75rem;
+    --controlStack-small-gap-auto: 1rem;
+    --controlStack-medium-gap-auto: 0.75rem;
+  }
+}
+@media (pointer: fine) {
+  :root {
+    --control-minTarget-auto: 1rem;
+    --controlStack-small-gap-auto: 0.5rem;
+    --controlStack-medium-gap-auto: 0.5rem;
+  }
+}
:root {
 --control-minTarget-fine: 1rem;
 --control-minTarget-coarse: 2.75rem;

@github-actions github-actions bot temporarily deployed to Preview (Storybook) May 31, 2024 13:04 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) May 31, 2024 13:06 Inactive
@lukasoppermann lukasoppermann merged commit 8b726b8 into main May 31, 2024
20 checks passed
@lukasoppermann lukasoppermann deleted the size-fix branch May 31, 2024 13:10
@primer primer bot mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant