Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] neutral scales #952

Closed
wants to merge 14 commits into from
Closed

[WIP] neutral scales #952

wants to merge 14 commits into from

Conversation

langermank
Copy link
Contributor

Why do my branches always break?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 68784a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank added the update snapshots Update visual regression test snapshots label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited
Loading

Design Token Contrast Check

light: ❌ 8 checks failed

Show results table for theme: light
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 15.79:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 6.11:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.05:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.44:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 14.05:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 5.44:1 4.5:1
fgColor-default vs. bgColor-accent-muted ✅ 13.88:1 4.5:1
fgColor-default vs. bgColor-success-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-open-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-danger-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-closed-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-attention-muted ✅ 14.65:1 4.5:1
fgColor-default vs. bgColor-severe-muted ✅ 14.26:1 4.5:1
fgColor-default vs. bgColor-done-muted ✅ 14.21:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted ✅ 14.24:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 5.19:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 4.62:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 4.62:1 4.5:1
fgColor-success vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 4.52:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 4.52:1 4.5:1
fgColor-open vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 4.52:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 4.52:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 4.66:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 4.66:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 4.66:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 4.66:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 4.86:1 4.5:1
fgColor-attention vs. bgColor-muted ❌ 4.33:1 4.5:1
fgColor-attention vs. bgColor-inset ❌ 4.33:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.03:1 4.5:1
fgColor-severe vs. bgColor-muted ❌ 4.47:1 4.5:1
fgColor-severe vs. bgColor-inset ❌ 4.47:1 4.5:1
fgColor-done vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-done vs. bgColor-muted ❌ 4.49:1 4.5:1
fgColor-done vs. bgColor-inset ❌ 4.49:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-sponsors vs. bgColor-muted ❌ 4.49:1 4.5:1
fgColor-sponsors vs. bgColor-inset ❌ 4.49:1 4.5:1
fgColor-accent vs. bgColor-accent-muted ✅ 4.56:1 4.5:1
fgColor-success vs. bgColor-success-muted ✅ 4.56:1 4.5:1
fgColor-open vs. bgColor-open-muted ✅ 4.56:1 4.5:1
fgColor-danger vs. bgColor-danger-muted ✅ 4.57:1 4.5:1
fgColor-closed vs. bgColor-closed-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-attention-muted ✅ 4.51:1 4.5:1
fgColor-severe vs. bgColor-severe-muted ✅ 4.54:1 4.5:1
fgColor-done vs. bgColor-done-muted ✅ 4.53:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted ✅ 4.55:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 6.11:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 5.19:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.86:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 5.03:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 5.04:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 5.04:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.45:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.07:1 3:1

dark: ❌ 4 checks failed

Show results table for theme: dark
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 17.38:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 6.49:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.7:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.49:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 18.86:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 7.05:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-default ✅ 15.57:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-muted ✅ 12.8:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-default ✅ 14.59:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-muted ✅ 12.01:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-default ✅ 15.5:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-muted ✅ 12.87:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-default ✅ 15.73:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-muted ✅ 13.15:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-default ✅ 14.82:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-muted ✅ 12.43:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-default ✅ 14.55:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-muted ✅ 12.11:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-default ✅ 15.68:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-muted ✅ 12.96:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-default ✅ 14.23:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-muted ✅ 11.71:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-default ✅ 15.63:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-muted ✅ 13.02:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 6.62:1 4.5:1
fgColor-success vs. bgColor-default ✅ 7.44:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 6.3:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-open vs. bgColor-default ✅ 7.44:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 6.3:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.64:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.64:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 7.49:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 6.34:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 8.13:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.61:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 4.74:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 6.09:1 4.5:1
fgColor-done vs. bgColor-default ✅ 6.32:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 5.35:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 6.86:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.62:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 4.75:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-accent-muted on bgColor-default ✅ 5.46:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-default ✅ 6.25:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-muted ✅ 5.14:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-default ✅ 6.64:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-muted ✅ 5.51:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-default ✅ 5.1:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-muted ❌ 4.27:1 4.5:1
fgColor-closed vs. bgColor-closed-muted on bgColor-default ✅ 4.81:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-default ✅ 6.27:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-muted ✅ 5.22:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-default ✅ 5.06:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-muted ❌ 4.18:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-default ✅ 5.18:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-muted ❌ 4.26:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-default ✅ 5.06:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-muted ❌ 4.21:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 5.3:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.64:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 4.65:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 4.57:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.56:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.01:1 3:1

@github-actions github-actions bot temporarily deployed to Preview (Storybook) May 15, 2024 00:20 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label May 15, 2024
@primer primer bot temporarily deployed to github-pages May 15, 2024 00:53 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) May 15, 2024 00:53 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Jun 12, 2024
@langermank langermank added the skip changeset Apply to PRs that should not result in a version bump. label Jun 12, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 12, 2024 17:44 Inactive
@langermank langermank added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Jun 12, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 12, 2024 18:01 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jun 12, 2024
@primer primer bot temporarily deployed to github-pages June 12, 2024 18:42 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) June 12, 2024 18:42 Inactive
@langermank langermank closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @joshblack