Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve action to output summary and fail on non-pr run #945

Merged
merged 1 commit into from
Apr 30, 2024
Merged

improve action to output summary and fail on non-pr run #945

merged 1 commit into from
Apr 30, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Apr 30, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners April 30, 2024 06:36
@lukasoppermann lukasoppermann requested a review from jonrohan April 30, 2024 06:36
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d769f60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 06:38 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from f7d6f49 to be4da4a Compare April 30, 2024 06:59
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:01 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from be4da4a to e631dce Compare April 30, 2024 07:06
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:08 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:15 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from 0f2f859 to b51353b Compare April 30, 2024 07:20
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:22 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from b51353b to 9b6bed4 Compare April 30, 2024 07:27
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:29 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:36 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:45 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:50 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 07:54 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 08:01 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from f2a8067 to c26fbb2 Compare April 30, 2024 08:03
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 08:05 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from c26fbb2 to 3848926 Compare April 30, 2024 08:36
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 08:38 Inactive
@lukasoppermann lukasoppermann force-pushed the check-contrast-action-fail-but-report branch from 3848926 to d769f60 Compare April 30, 2024 08:46
@github-actions github-actions bot temporarily deployed to Preview (Storybook) April 30, 2024 08:48 Inactive
@lukasoppermann lukasoppermann merged commit 8089a6e into main Apr 30, 2024
23 checks passed
@lukasoppermann lukasoppermann deleted the check-contrast-action-fail-but-report branch April 30, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukasoppermann