Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VRT tests #823

Merged
merged 17 commits into from
Mar 14, 2024
Merged

Improve VRT tests #823

merged 17 commits into from
Mar 14, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Mar 6, 2024 •
edited
Loading

  • Adds custom snapshots that are of a single color to improve diff checking
  • Removes unnecessary snapshots

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 681342d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

Variables changed 
No variables changed

@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview March 6, 2024 19:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 6, 2024 19:26 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview March 6, 2024 21:55 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 6, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 6, 2024
joshblack
joshblack reviewed Mar 6, 2024
View reviewed changes
e2e/storybook.test.ts Outdated Show resolved Hide resolved
@langermank @joshblack
Update e2e/storybook.test.ts
c3abc2b 
Co-authored-by: Josh Black <joshblack@github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview March 6, 2024 22:35 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 6, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 6, 2024
@joshblack joshblack added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Mar 7, 2024
@joshblack joshblack added the update snapshots Update visual regression test snapshots label Mar 7, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview March 7, 2024 16:20 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 7, 2024
@primer primer bot temporarily deployed to github-pages March 7, 2024 16:54 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 11, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 11, 2024
@primer primer bot temporarily deployed to github-pages March 11, 2024 19:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 11, 2024 19:05 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview March 11, 2024 21:10 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 11, 2024
@primer primer bot temporarily deployed to github-pages March 11, 2024 21:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 11, 2024 21:39 Inactive
@joshblack joshblack added the update snapshots Update visual regression test snapshots label Mar 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview March 13, 2024 19:56 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 13, 2024
@primer primer bot temporarily deployed to github-pages March 13, 2024 20:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview March 13, 2024 20:25 Inactive
@langermank langermank marked this pull request as ready for review March 13, 2024 21:21
@langermank langermank requested review from a team as code owners March 13, 2024 21:21
@langermank langermank merged commit d9ffc07 into main Mar 14, 2024
26 checks passed
@langermank langermank deleted the improve-vis-regressions branch March 14, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack left review comments

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann is a code owner automatically assigned from primer/css-reviewers

@owenniblock owenniblock Awaiting requested review from owenniblock owenniblock is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @joshblack