Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook docs cleanup #801

Merged
merged 10 commits into from
Feb 10, 2024
Merged

Storybook docs cleanup #801

merged 10 commits into from
Feb 10, 2024

Conversation

langermank
Copy link
Contributor

  • Bump Primer React
  • Remove theme override since its all CSS vars now WOOHOO
  • Remove demos as we plan to setup integration tests with Primer React 🎉
  • Add new docs tables for primer.style docs

@langermank langermank requested a review from a team as a code owner February 9, 2024 01:31
@langermank langermank requested review from a team, tobiasahlin and joshblack February 9, 2024 01:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: da40761

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank added the skip changeset Apply to PRs that should not result in a version bump. label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

Variables changed 
No variables changed

@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 9, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 9, 2024
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview February 9, 2024 01:48 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 9, 2024
@primer primer bot temporarily deployed to github-pages February 9, 2024 01:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 9, 2024 01:59 Inactive
@langermank langermank marked this pull request as draft February 9, 2024 02:00
@lukasoppermann lukasoppermann marked this pull request as ready for review February 9, 2024 07:28
@lukasoppermann lukasoppermann marked this pull request as draft February 9, 2024 07:28
lukasoppermann
lukasoppermann approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@lukasoppermann lukasoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview February 9, 2024 20:31 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 9, 2024
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview February 9, 2024 22:35 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 9, 2024
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview February 9, 2024 22:50 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 9, 2024
@primer primer bot temporarily deployed to github-pages February 9, 2024 22:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 9, 2024 23:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 10, 2024 02:31 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 10, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 10, 2024
@primer primer bot temporarily deployed to github-pages February 10, 2024 02:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 10, 2024 02:42 Inactive
@langermank langermank marked this pull request as ready for review February 10, 2024 02:46
@langermank langermank merged commit 3445871 into main Feb 10, 2024
26 checks passed
@langermank langermank deleted the storybook-cleanup branch February 10, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann lukasoppermann approved these changes

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin is a code owner automatically assigned from primer/css-reviewers

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @lukasoppermann