Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce opacity of shadow inset color #796

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Reduce opacity of shadow inset color #796

merged 5 commits into from
Jan 24, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

Reduced opacity for inset shadow to not look like a second border.

@lukasoppermann lukasoppermann requested a review from a team as a code owner January 10, 2024 14:57
@lukasoppermann lukasoppermann requested review from a team and langermank January 10, 2024 14:57
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 075f92f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Variables changed 
No variables changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Design Token Diff

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2024-01-12 16:05:25.843754113 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #801f0f;
 --color-scale-coral-8: #691105;
 --color-scale-coral-9: #510901;
-  --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+  --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
 --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
 --shadow-resting-medium: 0px 3px 6px 0px #424a531f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #801f0f;
   --color-scale-coral-8: #691105;
   --color-scale-coral-9: #510901;
-    --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+    --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
   --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
   --shadow-resting-medium: 0px 3px 6px 0px #424a531f;

/css/functional/themes/light-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-high-contrast.css	2024-01-12 16:05:26.219752914 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #6f0107;
 --color-scale-coral-8: #5b0002;
 --color-scale-coral-9: #430200;
-  --shadow-inset: inset 0px 1px 0px 0px #01040914;
+  --shadow-inset: inset 0px 1px 0px 0px #0104090a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #0104091a;
 --shadow-resting-small: 0px 1px 0px 0px #0104090f, 0px 1px 3px 0px #01040914;
 --shadow-resting-medium: 0px 3px 6px 0px #343b431f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #6f0107;
   --color-scale-coral-8: #5b0002;
   --color-scale-coral-9: #430200;
-    --shadow-inset: inset 0px 1px 0px 0px #01040914;
+    --shadow-inset: inset 0px 1px 0px 0px #0104090a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #0104091a;
   --shadow-resting-small: 0px 1px 0px 0px #0104090f, 0px 1px 3px 0px #01040914;
   --shadow-resting-medium: 0px 3px 6px 0px #343b431f;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2024-01-12 16:05:25.423755423 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #801f0f;
 --color-scale-coral-8: #691105;
 --color-scale-coral-9: #510901;
-  --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+  --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
 --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
 --shadow-resting-medium: 0px 3px 6px 0px #424a531f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #801f0f;
   --color-scale-coral-8: #691105;
   --color-scale-coral-9: #510901;
-    --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+    --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
   --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
   --shadow-resting-medium: 0px 3px 6px 0px #424a531f;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2024-01-12 16:05:24.955756884 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #801f0f;
 --color-scale-coral-8: #691105;
 --color-scale-coral-9: #510901;
-  --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+  --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
 --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
 --shadow-resting-medium: 0px 3px 6px 0px #424a531f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #801f0f;
   --color-scale-coral-8: #691105;
   --color-scale-coral-9: #510901;
-    --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+    --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
   --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
   --shadow-resting-medium: 0px 3px 6px 0px #424a531f;

@github-actions github-actions bot temporarily deployed to storybook-preview January 10, 2024 14:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview January 10, 2024 16:46 Inactive
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Jan 12, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jan 12, 2024
@joshblack joshblack added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Jan 12, 2024
@joshblack joshblack added the update snapshots Update visual regression test snapshots label Jan 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview January 12, 2024 15:57 Inactive
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Jan 12, 2024
@primer primer bot temporarily deployed to github-pages January 12, 2024 16:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview January 12, 2024 16:06 Inactive
@langermank langermank merged commit d842f87 into main Jan 24, 2024
26 checks passed
@langermank langermank deleted the insetShadow branch January 24, 2024 16:32
@primer primer bot mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasoppermann @langermank @joshblack