-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for HC-dark #793
Merged
Merged
Fixes for HC-dark #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca2dae2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Variables changedNo variables changed |
Design Token Diff
|
lukasoppermann
temporarily deployed
to
github-pages
December 21, 2023 09:45 — with
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
fix-HC-dark
branch
from
December 21, 2023 09:59
c349e88
to
f350b6b
Compare
lukasoppermann
temporarily deployed
to
github-pages
December 21, 2023 10:01 — with
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
December 21, 2023 10:07 — with
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
December 21, 2023 10:13 — with
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
December 21, 2023 10:41 — with
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
December 21, 2023 11:40 — with
GitHub Actions
Inactive
lukasoppermann
added
the
update snapshots
Update visual regression test snapshots
label
Dec 21, 2023
lukasoppermann
requested review from
a team,
rezrah,
mperrotti and
langermank
December 21, 2023 11:56
github-actions
bot
removed
the
update snapshots
Update visual regression test snapshots
label
Dec 21, 2023
langermank
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently all scales in Dark High Contrast have a bug where two colors are identical. This PR fixes that.