Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ts-node with tsx, needed for sd v4 #1015

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Replace ts-node with tsx, needed for sd v4 #1015

merged 1 commit into from
Jul 17, 2024

Conversation

lukasoppermann
Copy link
Contributor

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Jul 17, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners July 17, 2024 16:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 92b020b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Design Token Diff

No design tokens changed

@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 17, 2024 16:49 Inactive
@lukasoppermann lukasoppermann merged commit 35624fa into main Jul 17, 2024
28 checks passed
@lukasoppermann lukasoppermann deleted the tsx branch July 17, 2024 16:50
langermank pushed a commit that referenced this pull request Jul 18, 2024
@lukasoppermann @langermank
replace ts-node with tsx, needed for sd v4 (#1015)
05073db
Eric-Guo
Eric-Guo reviewed Aug 6, 2024
View reviewed changes
package.json
@@ -2,6 +2,9 @@
"name": "@primer/primitives",
"version": "8.2.3",
"description": "Typography, spacing, and color primitives for Primer design system",
"engines": {
"node": ">=18.18.0 <18.19.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know the reason why can not support node v20?

@Eric-Guo
Copy link

Eric-Guo commented Aug 6, 2024

I try to down grade node 18 and found I can only get 18.20.4, so this requirement still can not meet.

@Eric-Guo
Copy link

Eric-Guo commented Aug 6, 2024

I can following SO to set ignore-engines true in .yarnrc to ignore this engine setting now.

@lukasoppermann
Copy link
Contributor Author

lukasoppermann commented Aug 7, 2024 •
edited
Loading

@Eric-Guo there is an issue with a dependency, I think it is eslint, which requires higher node version.

Since I changed a lot around, I will re-check if it is still required. It may have been ts-node

@thomasbrus
Copy link

would appreciate that, also ran into this issue

@lukasoppermann
Copy link
Contributor Author

Will be fixed in here: #1038

@thomasbrus
Copy link

Thanks 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Guo Eric-Guo Eric-Guo left review comments

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasoppermann @Eric-Guo @thomasbrus