Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start adding ADRs to primer/primitives #1006

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Start adding ADRs to primer/primitives #1006

merged 3 commits into from
Jul 11, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Jul 10, 2024 •
edited
Loading

See ADR

@lukasoppermann lukasoppermann requested review from a team as code owners July 10, 2024 13:02
@lukasoppermann lukasoppermann requested a review from jonrohan July 10, 2024 13:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a6d0c06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 10, 2024 13:04 Inactive
@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label Jul 10, 2024
@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 10, 2024 13:17 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 10, 2024 16:26 Inactive
langermank
langermank approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lukas! 😄

@lukasoppermann lukasoppermann merged commit 743e4a6 into main Jul 11, 2024
24 checks passed
@lukasoppermann lukasoppermann deleted the lukasoppermann-init-adr branch July 11, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasoppermann @jonrohan @langermank