rename script (#1047)

primer · Sep 9, 2024 · b173e40 · b173e40
1 parent faead48
commit b173e40
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 33 deletions.
diff --git a/.github/workflows/a11y-contrast.yml b/.github/workflows/a11y-contrast.yml
@@ -10,7 +10,6 @@ jobs:
   changes:
     uses: ./.github/workflows/hasChanged.yml
 
-
   build:
     needs: changes
     if: needs.changes.outputs.tokens == 'true' || github.event_name == 'workflow_dispatch'
@@ -32,8 +31,8 @@ jobs:
       - name: Install dependencies
         run: npm ci --no-audit --no-fund --ignore-scripts
 
-      - name: Build v8 tokens
-        run: npm run build:v8
+      - name: Build tokens
+        run: npm run build:tokens
 
       - name: Run required checks
         run: |
@@ -47,7 +46,7 @@ jobs:
           script: |
             const results = require('./color-contrast-check.json');
             const faildChecks = results.reduce((acc, {failingContrast}) => acc + failingContrast, 0);
-            
+
             // prepare comment body
             const resultsMarkdown = '## Design Token Contrast Check\n\n' + 
               results.map(({theme, failingContrast, markdownTable}) => 
@@ -71,24 +70,24 @@ jobs:
             else {
               core.info('\u001b[32;1m✅ All contrast checks passed!')
             }
-      
+
       - name: Report check results as comment
         if: github.event_name == 'pull_request'
         uses: actions/github-script@v7
         with:
           script: |
             const resultsMarkdown = `${{ steps.check-results.outputs.markdown }}`
-            
+
             // get comments
             const {data: comments} = await github.rest.issues.listComments({
               issue_number: context.issue.number,
               owner: context.repo.owner,
               repo: context.repo.repo
             });
-            
+
             // get token issue
             const tokenCheckComment = comments.filter(comment => comment.body.includes('## Design Token Contrast Check'));
-            
+
             // if token issue exists, update it
             if(tokenCheckComment.length > 0) {
               await github.rest.issues.updateComment({
@@ -118,7 +117,7 @@ jobs:
             // output results to summary
             core.summary.addRaw(resultsMarkdown, true)
             core.summary.write({overwrite: true})
-  
+
   Fail_action_on_contrast_failing:
     needs: build
     name: Fail action on contrast failing
@@ -146,7 +145,7 @@ jobs:
               owner: context.repo.owner,
               repo: context.repo.repo
             });
-            
+
             // get token issue
             const tokenCheckComment = comments.filter(comment => comment.body.includes('## Design Token Contrast Check'));
 

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,8 +24,8 @@ jobs:
       - name: Install dependencies
         run: npm ci --no-audit --no-fund --ignore-scripts
 
-      - name: Build v8 tokens
-        run: npm run build:v8
+      - name: Build tokens
+        run: npm run build:tokens
 
       - name: Build fallbacks
         run: npm run build:fallbacks

diff --git a/.github/workflows/diff-v8.yml b/.github/workflows/diff-v8.yml
@@ -34,13 +34,13 @@ jobs:
         run: npm ci --no-audit --no-fund --include=dev --ignore-scripts
 
       - name: Build tokens (pr)
-        run: npm run build:v8
+        run: npm run build:tokens
 
       - name: Install dependencies (base)
         run: pushd base; npm i --no-audit --no-fund --ignore-scripts; popd
 
       - name: Build tokens (base)
-        run: pushd base; npm run build:v8; popd
+        run: pushd base; npm run build:tokens; popd
 
       - name: Install dependecies for diffing
         run: npm install shelljs
@@ -55,7 +55,7 @@ jobs:
             const globber = await glob.create(cssFolder + '/**/**/*.css')
             const files = await globber.glob()
             const fs = require('fs')
-            
+
             // create file to store diffs
             const diffFilePath = 'diff_output.json'
             shell.touch(diffFilePath)
@@ -91,7 +91,7 @@ jobs:
             .filter(item => {
               return item.diff !== ''
             })
-            
+
             // store diffs in file
             fs.writeFileSync(diffFilePath, JSON.stringify(diffs, null, ' '))
 
@@ -101,7 +101,7 @@ jobs:
           script: |
             const fs = require('fs')
             const diffFilePath = "${{ steps.diff-files.outputs.diffFilePath }}"
-            
+
             // check if file exists
             if(!fs.existsSync(diffFilePath)) {
               return
@@ -110,9 +110,9 @@ jobs:
             const diffs = JSON.parse(fs.readFileSync(diffFilePath, 'utf8'))
 
             core.summary.clear()
-            
+
             core.summary.addHeading('V8 Design Token Diff', '1')
-            
+
             if (diffs.length === 0) {
               core.summary.addRaw('No design tokens changed', true)
             } else {
@@ -139,7 +139,7 @@ jobs:
           script: |
             const fs = require('fs')
             const diffFilePath = "${{ steps.diff-files.outputs.diffFilePath }}"
-            
+
             // check if file exists
             if(!fs.existsSync(diffFilePath)) {
               return
@@ -213,7 +213,7 @@ jobs:
               owner: context.repo.owner,
               repo: context.repo.repo
             });
-            
+
             // get comment if exists
             const existingComment = comments.filter(comment => comment.body.includes('## Design Token Diff'));
 
@@ -228,4 +228,4 @@ jobs:
 
             // remove summary
             core.summary.clear()
-            core.summary.write({overwrite: true})
+            core.summary.write({overwrite: true})
diff --git a/.github/workflows/release_canary.yml b/.github/workflows/release_canary.yml
@@ -27,8 +27,8 @@ jobs:
       - name: Install dependencies
         run: npm ci --no-audit --no-fund --include=dev
 
-      - name: Build v8 tokens
-        run: npm run build:v8
+      - name: Build tokens
+        run: npm run build:tokens
 
       - name: Create .npmrc
         run: |
@@ -66,7 +66,7 @@ jobs:
             core.setOutput('packageVersion', package.version);
             // Output the package name for next step
             core.setOutput('packageName', package.name);
-      
+
       - name: Output canary version to summary
         env:
           VERSION: ${{ steps.commitStatus.outputs.packageVersion }}

diff --git a/.github/workflows/release_candidate.yml b/.github/workflows/release_candidate.yml
@@ -26,8 +26,8 @@ jobs:
       - name: Install dependencies
         run: npm ci --no-audit --no-fund --include=dev
 
-      - name: Build tokens v8
-        run: npm run build:v8
+      - name: Build tokens
+        run: npm run build:tokens
 
       - name: Create .npmrc
         run: |
@@ -71,4 +71,4 @@ jobs:
           PACKAGE_NAME: ${{ steps.commitStatus.outputs.packageName }}
         run: |
           echo "### Latest release candidate" >> $GITHUB_STEP_SUMMARY
-          echo "[v$VERSION](https://unpkg.com/$PACKAGE_NAME@$VERSION/)" >> $GITHUB_STEP_SUMMARY
+          echo "[v$VERSION](https://unpkg.com/$PACKAGE_NAME@$VERSION/)" >> $GITHUB_STEP_SUMMARY
diff --git a/.github/workflows/update_visual_snapshots.yml b/.github/workflows/update_visual_snapshots.yml
@@ -36,8 +36,8 @@ jobs:
         run: npm ci --no-audit --no-fund --ignore-scripts
       - name: Install browsers
         run: npx playwright install --with-deps
-      - name: Build v8 tokens
-        run: npm run build:v8
+      - name: Build tokens
+        run: npm run build:tokens
       - name: Build storybook
         working-directory: docs/storybook
         run: |

diff --git a/package.json b/package.json
@@ -22,9 +22,8 @@
   },
   "homepage": "https://github.com/primer/primitives#readme",
   "scripts": {
-    "build": "npm run build:v8 && npm run build:fallbacks && npm run build:figma && npm run build:config",
-    "build:next": "echo '\\033[31m 🛑 Use npm run build instead of npm run build:next\\033[0m'",
-    "build:v8": "tsx ./scripts/buildTokens.ts",
+    "build": "npm run build:tokens && npm run build:fallbacks && npm run build:figma && npm run build:config",
+    "build:tokens": "tsx ./scripts/buildTokens.ts",
     "build:fallbacks": "tsx ./scripts/buildFallbacks.ts",
     "build:figma": "tsx scripts/buildFigma.ts",
     "build:config": "tsc -p buildConfig.tsconfig.jsonc",