converting line height to pixel value

primer · Apr 19, 2024 · 5843c1a · 5843c1a
1 parent 7934ec3
commit 5843c1a
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/.changeset/few-seas-invite.md b/.changeset/few-seas-invite.md
@@ -0,0 +1,5 @@
+---
+'@primer/primitives': patch
+---
+
+Convert lineHeight from float to pixel value for figma
diff --git a/src/PrimerStyleDictionary.ts b/src/PrimerStyleDictionary.ts
@@ -23,7 +23,11 @@ import {
   shadowToCss,
   typographyToCss,
   dimensionToRemPxArray,
+<<<<<<< HEAD
   floatToPixel,
+=======
+  convertWithFontSizeToPixel,
+>>>>>>> c920fd97 (converting line height to pixel value)
 } from './transformers'
 import {
   javascriptCommonJs,

diff --git a/src/platforms/figma.ts b/src/platforms/figma.ts
@@ -28,6 +28,7 @@ export const figma: PlatformInitializer = (outputFile, prefix, buildPath, option
     // 'name/pathToSlashNotation',
     'figma/attributes',
     'fontFamily/figma',
+    'float/pixel',
     'dimension/pixelUnitless',
     // 'border/figma',
     // 'typography/figma',

diff --git a/src/tokens/functional/typography/typography.json b/src/tokens/functional/typography/typography.json
@@ -34,8 +34,8 @@
   "text": {
     "display": {
       "lineBoxHeight": {
-        "$value": "56px",
-        "$type": "dimension",
+        "$value": 1.4,
+        "$type": "number",
         "$extensions": {
           "org.primer.data": {
             "fontSize": 40
@@ -52,7 +52,16 @@
       },
       "lineHeight": {
         "$value": 1.4,
-        "$type": "number"
+        "$type": "number",
+        "$extensions": {
+          "org.primer.data": {
+            "fontSize": 40
+          },
+          "org.primer.figma": {
+            "collection": "typography",
+            "scopes": ["all"]
+          }
+        }
       },
       "weight": {
         "$value": "{base.text.weight.medium}",