Skip to content

Commit

Permalink
Update degraded-experiences.mdx (#678)
Browse files Browse the repository at this point in the history
* Update degraded-experiences.mdx

* Update content/ui-patterns/degraded-experiences.mdx

Co-authored-by: Cameron Dutro <camertron@gmail.com>

---------

Co-authored-by: Cameron Dutro <camertron@gmail.com>
  • Loading branch information
pksjce and camertron authored Nov 29, 2023
1 parent ce6ba33 commit 2d5a368
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions content/ui-patterns/degraded-experiences.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,11 @@ Be mindful that rendering too many error messages on the page in `fg.warning` co
src="https://github.com/primer/design/assets/2313998/d3b0f293-64fc-4bd5-94af-041d92090874"
/>

If the affected area is large enough, replace the affected UI with a [blankstate](/components/blankslate) component that explains why the expected UI isn't there.
If the affected area is large enough, replace the affected UI with a [blankslate](/components/blankslate) component that explains why the expected UI isn't there.

#### Dialogs (modal and non-modal)

If the content of a dialog is not critical and cannot be rendered, prevent the dialog from even being opened. For non-critical dialogs that appear on hover, remove the hover interaction. For non-critical dialogs that appear on click, remove the button that triggers the dialog. For example, if a user's profile data cannot is unavailable, don't show a hovercard when their avatar is hovered.
If the content of a dialog is not critical and cannot be rendered, prevent the dialog from even being opened. For non-critical dialogs that appear on hover, remove the hover interaction. For non-critical dialogs that appear on click, remove the button that triggers the dialog. For example, if a user's profile data is unavailable, don't show a hovercard when their avatar is hovered.

If the dialog is a core part of a workflow, replace the content of the dialog with a message explaining why the expected UI isn't there. If you're using a dialog component that supports error states (for example, [select panel](/components/select-menu#select-panel)), follow the component's guidelines for rendering error messages.

Expand All @@ -185,7 +185,7 @@ If the dialog is a core part of a workflow, replace the content of the dialog wi
src="https://github.com/primer/design/assets/2313998/653cc04b-e88e-4235-8c04-47b8dba57351"
/>

If you're not using a component that supports error states, replace the content of the dialog with a [blankstate](/components/blankslate) component explaining why the expected UI isn't there.
If you're not using a component that supports error states, replace the content of the dialog with a [blankslate](/components/blankslate) component explaining why the expected UI isn't there.

<img
width="960"
Expand Down

0 comments on commit 2d5a368

Please sign in to comment.