Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Rowspan not working correctly when returning it from passThrough bodyCell (of Column) #7156

Open
4 tasks
ahkiva opened this issue Jan 27, 2025 · 1 comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone

Comments

@ahkiva
Copy link

ahkiva commented Jan 27, 2025

Describe the bug

If bodyCell pt function returns rowspan ({rowspan: '2'}) in DataTable component then it does not work, but it works when rowSpan is in camelCase (colspan works correctly). I guess rowspan (all lowercase) should work also.
https://stackblitz.com/edit/p1zsnpbi-vo2vl6p9?file=src%2FApp.vue

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/p1zsnpbi-vo2vl6p9?file=src%2FApp.vue

Environment

Add

Vue version

3.2.45

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

In DataTable component, add bodyCell pt function to Column and let the function return {rowspan: '2'} then it will not work (only works if using {rowSpan: '2'}).

Expected behavior

Lowercase letters should also work rowspan (it works for colspan).

@ahkiva ahkiva added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 27, 2025
@tugcekucukoglu tugcekucukoglu added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 4, 2025
@tugcekucukoglu tugcekucukoglu added this to the Future milestone Feb 4, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Due to PrimeTek's demanding roadmap for PrimeVue and the limited bandwidth of the core team, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
Status: Review
Development

No branches or pull requests

2 participants