[DEVEX-2333]: Implement caching using dynamo #183
Conversation
MaeIsBad
force-pushed
the
DEVEX-2333/task/implement-caching-using-dynamo
branch
from
32f1a3f to
1b53bae
Compare
There was a problem hiding this comment.
Dumb question: what if the users create the table themselves but the key is not called key and the value is not token?
There was a problem hiding this comment.
Stuff breaks. I guess we can document the table setup?
There was a problem hiding this comment.
Yes! I would absolutely do that then
There was a problem hiding this comment.
Done to the best of my ability. I don't know that much about aws though
| let redis_conn = config.cache_type().redis_connection_url().to_string(); | ||
| let encryption_key = config.token_encryption_key().to_string(); | ||
| Box::new( | ||
| cache::RedisCache::new(redis_conn, encryption_key) | ||
| .await | ||
| .map_err(Into::<CacheError>::into)?, | ||
| ) |
There was a problem hiding this comment.
I think I got lost in the code but why does this default to the RedisCache? Backwards compatibility...?
There was a problem hiding this comment.
yep, that's what we did before
Co-authored-by: Cristiano Piemontese <cristiano.piemontese@prima.it>
Co-authored-by: Cristiano Piemontese <cristiano.piemontese@prima.it>
Co-authored-by: Cristiano Piemontese <cristiano.piemontese@prima.it>
MaeIsBad
force-pushed
the
DEVEX-2333/task/implement-caching-using-dynamo
branch
from
82e39e7 to
577bf47
Compare
doing that without breaking backwards compat is really weird and I don't really wanna think about it
Would you mind if we made that a separate task? I think the documentation on docs.rs makes these features fairly easy to discover and I've spent so much time on this card that I'd really like to just get it done |
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/DEVEX-2333
I guess this is done. Idk I'm tired of this library, I don't wanna touch it anymore