[COLIB-522]: Fix the trace propagation for engine gRPC calls #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-procopiuc
requested review from
fusillicode,
cpiemontese and
HerveHuneau
pavel-procopiuc
force-pushed
the
COLIB-522
branch
from
32ffbc6 to
301b459
Compare
pavel-procopiuc
force-pushed
the
COLIB-522
branch
from
301b459 to
9ebef78
Compare
pavel-procopiuc
force-pushed
the
COLIB-522
branch
from
9ebef78 to
a0d0066
Compare
pavel-procopiuc
force-pushed
the
COLIB-522
branch
from
a0d0066 to
021b81a
Compare
|
@cpiemontese I have rebased this PR onto master |
cpiemontese
approved these changes
Dec 3, 2024
|
It does work, I've done some limited testing of the same code on another project and got a pretty fine trace, so no worries here |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/COLIB-522
This PR adds a helper propagator that injects the opentelemtry context necessary for DataDog to link traces between different services when calling them via gRPC.
This is based on #177 so it might contain a lot of unrelated changes on the first glance. The actual change is in the last commit:
[COLIB-522]: Fix the trace propagation for engine gRPC calls