Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate language translations processing and use new JSONs for templating #127

Merged
merged 30 commits into from
Dec 27, 2023

Conversation

FedericoDM
Copy link
Contributor

Describe Your Changes

  • Created a python script that automatically creates the JSON from an Excel file
  • New JSONs are used in the required templates

Non-Obvious Technical Information

  • The Excel's file name is hard coded on the utils/constants.py script.

Checklist Before Requesting a Review

  • The code runs successfully.
root@LAPTOP-RMMEN33V:/mnt/c/Users/fdmol/Desktop/Prijateli-project/PrijateliTree# make process_translations
python3 ./prijateli_tree/app/utils/process_translations.py

Some of the templates look like this:

Start of game:

image

First round:

image

Second round:

image

Waiting:

image

End of game:

image

End of session:

image

Thank you screen:

image

@FedericoDM FedericoDM marked this pull request as ready for review December 27, 2023 02:59
Copy link
Collaborator

@anisfeld anisfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@FedericoDM FedericoDM merged commit 1861d85 into main Dec 27, 2023
2 checks passed
@FedericoDM FedericoDM deleted the language-adjusts branch December 27, 2023 04:17
@FedericoDM FedericoDM changed the title Automate language automation and use new JSONs for templating Automate language translations processing and use new JSONs for templating Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants