Avatar에 name(= alt) 속성 값 부여를 통해 접근성 개선 #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live-small
reviewed
May 19, 2023
| <Avatar | ||
| src={user.profileImgUrl} | ||
| size='sm' | ||
| name={`${user.nickname} 아바타 사진`} |
There was a problem hiding this comment.
ask;
avatar의 name이 alt가 되는 거 맞나요?
There was a problem hiding this comment.
네, 개발 서버 돌려서 alt로 뜨는 거 확인했습니다.
| @@ -60,6 +60,7 @@ const UserIconForm = ({ | |||
| pointerEvents='none' | |||
| pos='relative' | |||
| border='2px solid gray' | |||
| name='유저 사진' | |||
There was a problem hiding this comment.
ask;
개인적으로 한국사람들이 보거나 들을 용어다보니, 한국어를 사용하는 건 어떨까요? ex) 유저 사진 -> 사용자 사진
There was a problem hiding this comment.
좋습니다! 반영해두겠습니다.
edit 페이지에서 useGetUser를 통해 data의 nickname을 사용하면 되겠네요. 원래 있었는데 제가 몰랐던 건지, 아니면 백엔드분들이 수정해주신 건지는 잘 모르겠습니다! nickname을 사용하는 걸로 수정해두겠습니다.
이건 아직 undefined네요. 백엔드 건우님한테 다시 요청해두겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Linked Issues
📖 구현 내용
✅ PR 포인트 & 궁금한 점