Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/QFEED-55-exception-design #4

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feature/QFEED-55-exception-design #4

merged 3 commits into from
Nov 27, 2024

Conversation

jhk01007
Copy link
Collaborator

πŸ“Œ 과제 μ„€λͺ…

μ˜ˆμ™Έμ— λŒ€ν•œ μ „λ°˜μ μΈ 틀을 μž‘μ„±ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

πŸ‘©β€πŸ’» μš”κ΅¬ 사항과 κ΅¬ν˜„ λ‚΄μš©

common

  • ErrorCode
    • μΈν„°νŽ˜μ΄μŠ€
    • λ‚΄λΆ€μ—λŠ” μƒνƒœμ½”λ“œ, μ—λŸ¬μ½”λ“œ, μ—λŸ¬λ©”μ‹œμ§€λ₯Ό κ°–κ³  μžˆλŠ” 객체
  • GlobalErrorCode
  • CustomException
  • CustomExceptionλ₯Ό 상속받은 계측별 μ˜ˆμ™Έ
    • DomainException
    • ApplicationException
    • InfraException
    • ApiException
    • ExternalAPIException

api

  • ControllerAdvice

api/application/infra/external-api/domain

  • 도메인이름/exception 디렉토리에
    • <도메인>Exception을 상속받은 μ˜ˆμ™Έ 클래슀
    • BaseErrorCodeλ₯Ό κ΅¬ν˜„ν•œ <도메인>ErrorCode Enum
image

βœ… PR 포인트 & κΆκΈˆν•œ 점

@jhk01007
[QFEED-55] Feat: Common Layer: μ—λŸ¬μ½”λ“œ Enum μΆ”κ°€
de4deb8 
- BaseErrorCode: μ—λŸ¬μ½”λ“œ μΈν„°νŽ˜μ΄μŠ€
- GlobalErrorCode: 전역적인 μ—λŸ¬μ½”λ“œ
- ErrorInfo: μ˜ˆμ™Έμ •λ³΄
@jhk01007
[QFEED-55] Feat: Common Layer: 계측별 λΆ€λͺ¨ν΄λž˜μŠ€ μΆ”κ°€
c3f54de 
- ErrorCodeConstants: μ—λŸ¬μ½”λ“œμ— λŒ€ν•œ μƒμˆ˜κ°’ μ €μœΌμ΄
@jhk01007
[QFEED-55] Feat: Api 계측: ControllerAdvice, μ—λŸ¬ 응닡 클래슀, Validation μ—λŸ¬ 코…
60913f0 
β€¦λ“œ μΆ”κ°€
@jhk01007 jhk01007 self-assigned this Nov 27, 2024
jieun5119
jieun5119 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@jieun5119 jieun5119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€πŸ‘

@jhk01007 jhk01007 merged commit 00edee3 into develop Nov 27, 2024
1 check failed
@jhk01007 jhk01007 deleted the feature/QFEED-55-exception-design branch November 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieun5119 jieun5119 jieun5119 approved these changes

@wjdwltn wjdwltn wjdwltn approved these changes

Assignees

@jhk01007 jhk01007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhk01007 @wjdwltn @jieun5119