Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] #28 견주정보 입력 UI 제작 #98

Merged
merged 28 commits into from
Nov 29, 2024
Merged

Conversation

kimjuyoung99
Copy link
Collaborator

@kimjuyoung99 kimjuyoung99 commented Nov 27, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #28

  • 견주정보 입력 UI 제작
  • 아바타 svg 파일 10개를 하나씩 불러오는 것이 불필요하다 느껴 Barrel 패턴을 적용하여 assets 디렉토리에 index파일을 하나 만들어 한꺼번에 export 하였습니다
  • 아바타 선택 전 : 버튼 비활성화 / 선택 후 : 버튼 활성화, 컬러 변경
  • 아바타 변경 시 아바타 모달에 직전에 선택한 캐릭터 체크표시 유지
  • svg파일 몇개가 미묘하게 크기가 작아 따로 스타일 컴포넌트에서 조정 작업 했습니다.
  • 성별선택 공통컴포넌트, 스크롤 바 커스텀
  • 내일 토스트, 예외처리, 위치등록 구현하겠습니다

🖼️ Screenshots

Left Video
Right Video

@github-actions github-actions bot requested a review from saseungmin November 27, 2024 05:25
@kimjuyoung99 kimjuyoung99 linked an issue Nov 27, 2024 that may be closed by this pull request
@github-actions github-actions bot requested review from shlee9999 and wonill November 27, 2024 05:25
@kimjuyoung99 kimjuyoung99 added the enhancement New feature or request label Nov 27, 2024
Copy link

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.8 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 0 ms
Cumulative Layout Shift 🟢 0.008
Speed Index 🟢 2.8 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 89
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 3.7 s
Total Blocking Time 🟢 10 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟢 95
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 2.8 s
Total Blocking Time 🟢 10 ms
Cumulative Layout Shift 🟢 0.006
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.7 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.002
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@kimjuyoung99
Copy link
Collaborator Author

@saseungmin
멘토님 리뷰 살짝 부탁드립니다! 특별히 막히는 부분은 없고 그냥 UI 하나 짠 건데 컴포넌트 구조나 CSS 상대단위 잘 쓰고 있는게 맞는지 궁금합니다..!

wonill
wonill previously approved these changes Nov 27, 2024
src/modals/RegisterAvatarModal/styles.ts Outdated Show resolved Hide resolved
src/modals/RegisterAvatarModal/index.tsx Outdated Show resolved Hide resolved
src/pages/RegisterPage/Register/styles.ts Show resolved Hide resolved
Copy link

@saseungmin saseungmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요! 😊

src/modals/RegisterAvatarModal/index.tsx Outdated Show resolved Hide resolved
src/modals/RegisterAvatarModal/index.tsx Show resolved Hide resolved
src/modals/RegisterAvatarModal/index.tsx Outdated Show resolved Hide resolved
src/pages/RegisterPage/Register/index.tsx Outdated Show resolved Hide resolved
src/modals/RegisterAvatarModal/styles.ts Outdated Show resolved Hide resolved
@kimjuyoung99 kimjuyoung99 requested a review from wonill November 27, 2024 10:35
wonill
wonill previously approved these changes Nov 27, 2024
shlee9999
shlee9999 previously approved these changes Nov 28, 2024
src/pages/RegisterPage/Register/styles.ts Outdated Show resolved Hide resolved
@kimjuyoung99 kimjuyoung99 dismissed stale reviews from shlee9999 and wonill via 2a8cdd2 November 28, 2024 17:07
@kimjuyoung99 kimjuyoung99 merged commit 6b54d59 into develop Nov 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] 견주정보 입력
4 participants