Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] #66 산책에 사용되는 공통 모달 UI 구현 #95

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

ruehan
Copy link
Collaborator

@ruehan ruehan commented Nov 26, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #66

산책에서 사용되는 공통 모달의 UI를 구현했습니다.

🖼️ Screenshots

IMG_2135 IMG_2137 IMG_2136
IMG_2132 IMG_2130 IMG_2131

Close #66

@ruehan ruehan added the enhancement New feature or request label Nov 26, 2024
@ruehan ruehan self-assigned this Nov 26, 2024
@ruehan ruehan linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 86
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.0 s
Largest Contentful Paint 🟠 4.0 s
Total Blocking Time 🟢 30 ms
Cumulative Layout Shift 🟢 0.008
Speed Index 🟢 2.0 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 89
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 3.7 s
Total Blocking Time 🟢 10 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟢 95
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 2.8 s
Total Blocking Time 🟢 10 ms
Cumulative Layout Shift 🟢 0.006
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.7 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.002
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

kimjuyoung99
kimjuyoung99 previously approved these changes Nov 26, 2024
@kimjuyoung99 kimjuyoung99 self-requested a review November 27, 2024 02:10
@ruehan ruehan merged commit fb3bea7 into develop Nov 27, 2024
1 check passed
@github-actions github-actions bot deleted the 66-design/walk-common-modal branch December 4, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] 산책 페이지 공통 모달
3 participants