Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] #45 마이페이지 알림 설정 페이지 #76

Merged
merged 7 commits into from
Nov 24, 2024
Merged

[Design] #45 마이페이지 알림 설정 페이지 #76

merged 7 commits into from
Nov 24, 2024

Conversation

kimjuyoung78
Copy link
Collaborator

@kimjuyoung78 kimjuyoung78 commented Nov 22, 2024 •
edited
Loading

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #45

마이페이지 - 알림 설정 페이지 작업했습니다.

  • 모든 알림 조작 시 다른 알람 작동 시나리오 미정
  • 헤더 공통컴포넌트 도입 아직 안함

🖼️ Screenshots

DDang-.mp4

@github-actions github-actions bot requested review from shlee9999 and wonill November 22, 2024 08:30
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Report

Category Score
🟠 Performance 86
🟢 Accessibility 100
🟢 Best Practices 100
🟢 SEO 100

Detailed Metrics

Metric Value
🟠 First Contentful Paint 1.8 s
🟠 Largest Contentful Paint 4.0 s
🟢 Total Blocking Time 70 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.8 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@kimjuyoung78 kimjuyoung78 changed the title [Desigin] #45 가족 코드 입력 페이지 [Desigin] #45 마이페이지 Nov 22, 2024
@kimjuyoung78 kimjuyoung78 changed the title [Desigin] #45 마이페이지 [Design] #45 마이페이지 알람 Nov 22, 2024
wonill
wonill previously approved these changes Nov 22, 2024
View reviewed changes
@kimjuyoung78 kimjuyoung78 changed the title [Design] #45 마이페이지 알람 [Design] #45 마이페이지 알림 설정 페이지 Nov 22, 2024
@kimjuyoung78 kimjuyoung78 linked an issue Nov 22, 2024 that may be closed by this pull request
[Feature] 마이페이지( 알림설정, 탈퇴 ) #45
Closed
shlee9999
shlee9999 requested changes Nov 23, 2024
View reviewed changes
src/pages/MyPage/SettingModal/styles.ts Show resolved Hide resolved
src/pages/MyPage/index.tsx Outdated Show resolved Hide resolved
src/pages/MyPage/index.tsx Outdated Show resolved Hide resolved
src/pages/MyPage/SettingModal/index.tsx Outdated Show resolved Hide resolved
src/pages/MyPage/SettingModal/index.tsx Outdated Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
shlee9999
shlee9999 previously approved these changes Nov 24, 2024
View reviewed changes
@kimjuyoung78 kimjuyoung78 requested a review from wonill November 24, 2024 13:09
@kimjuyoung78 kimjuyoung78 merged commit ae8b07b into develop Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonill wonill wonill approved these changes

@shlee9999 shlee9999 shlee9999 approved these changes

Assignees

@kimjuyoung78 kimjuyoung78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 마이페이지( 알림설정, 탈퇴 )
3 participants
@kimjuyoung78 @shlee9999 @wonill