Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] #30 산책 지도 UI #72

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Design] #30 산책 지도 UI #72

merged 1 commit into from
Nov 22, 2024
+563 −321

Conversation

ruehan
Copy link
Collaborator

@ruehan ruehan commented Nov 22, 2024 •
edited
Loading

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #30

산책 지도 UI를 구현했습니다.

🖼️ Screenshots

산책 내 위치 내 위치 아닌 경우 산책 시작 경로 표시
IMG_2124 IMG_2125 IMG_2126 IMG_2127

Close #30

@ruehan ruehan added the enhancement New feature or request label Nov 22, 2024
@ruehan ruehan self-assigned this Nov 22, 2024
@ruehan ruehan linked an issue Nov 22, 2024 that may be closed by this pull request
[Design] 산책 지도 관련 #30
Closed
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Report

Category Score
🟠 Performance 87
🟢 Accessibility 91
🟢 Best Practices 100
🟢 SEO 92

Detailed Metrics

Metric Value
🟠 First Contentful Paint 1.8 s
🟠 Largest Contentful Paint 3.9 s
🟢 Total Blocking Time 10 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.8 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

kimjuyoung99
kimjuyoung99 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@kimjuyoung99 kimjuyoung99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완벽합니다

@ruehan ruehan merged commit 91230f2 into develop Nov 22, 2024
2 checks passed
@github-actions github-actions bot deleted the 30-design/walk-map-ui branch November 30, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonill wonill wonill approved these changes

@kimjuyoung99 kimjuyoung99 kimjuyoung99 approved these changes

Assignees

@ruehan ruehan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] 산책 지도 관련
3 participants
@ruehan @kimjuyoung99 @wonill