Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] #20 홈페이지 디자인 #64

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[Design] #20 홈페이지 디자인 #64

merged 4 commits into from
Nov 22, 2024

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Nov 21, 2024 •
edited
Loading

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #20

홈페이지 디자인했습니다.

추가 기능

  1. ActionButton fontWeight 설정 가능
  2. [Feature] 공통 컴포넌트 작성 #15 브랜치의 Typo color 버그 수정이 필요하여 중간에 merge함

🖼️ Screenshots

{A2A3ABBB-008A-4277-A617-D6089376B69F}

@shlee9999 shlee9999 linked an issue Nov 21, 2024 that may be closed by this pull request
[Design] 홈페이지 #20
Closed
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Report

Category Score
🟠 Performance 88
🟢 Accessibility 91
🟢 Best Practices 100
🟢 SEO 92

Detailed Metrics

Metric Value
🟢 First Contentful Paint 1.7 s
🟠 Largest Contentful Paint 3.8 s
🟢 Total Blocking Time 10 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.7 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 changed the title 20 design/home page [Design] #20 홈페이지 디자인 Nov 21, 2024
@shlee9999 shlee9999 enabled auto-merge November 21, 2024 10:30
ruehan
ruehan previously approved these changes Nov 21, 2024
View reviewed changes
kimjuyoung78
kimjuyoung78 previously approved these changes Nov 21, 2024
View reviewed changes
@shlee9999 shlee9999 dismissed stale reviews from kimjuyoung78 and ruehan via e8f7cdb November 22, 2024 00:08
@shlee9999 shlee9999 merged commit 9f69f4e into develop Nov 22, 2024
1 check passed
@github-actions github-actions bot deleted the 20-design/home-page branch November 29, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimjuyoung78 kimjuyoung78 kimjuyoung78 approved these changes

@ruehan ruehan ruehan approved these changes

Assignees

@shlee9999 shlee9999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] 홈페이지
3 participants
@shlee9999 @ruehan @kimjuyoung78