Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] #15 CloseButton, PrevButton #57

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Feature] #15 CloseButton, PrevButton #57

merged 2 commits into from
Nov 21, 2024

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Nov 21, 2024 •
edited
Loading

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #15

하위 페이지 또는 모달에서 자주 쓰이는 CloseButton, PrevButton 추가하였습니다.

🖼️ Screenshots

{D9626EED-890D-4680-A820-600BC8DFBE0E}

{8725E0DE-6E21-4B9B-9928-918B9039E50C}

@github-actions github-actions bot requested review from ruehan and wonill November 21, 2024 06:10
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Report

Category Score
🟢 Performance 95
🟢 Accessibility 100
🟢 Best Practices 100
🟢 SEO 100

Detailed Metrics

Metric Value
🟢 First Contentful Paint 1.6 s
🟠 Largest Contentful Paint 2.9 s
🟢 Total Blocking Time 0 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 enabled auto-merge November 21, 2024 06:17
@shlee9999 shlee9999 merged commit 5d9e1c1 into develop Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonill wonill wonill approved these changes

@ruehan ruehan ruehan approved these changes

Assignees

@shlee9999 shlee9999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlee9999 @ruehan @wonill