Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] #38 알림창 데이터 바인딩 #132

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Dec 6, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #38

무한 스크롤 이용하여 알림창 데이터 바인딩

🖼️ Screenshots

{8B48DFA7-A8F0-49A7-8E5B-604809D97525}

@shlee9999 shlee9999 linked an issue Dec 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 6, 2024

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 97
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.8 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 60 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 2.8 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 87
Accessibility 🟢 95
Best Practices 🟠 83
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.2 s
Largest Contentful Paint 🟠 3.8 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.003
Speed Index 🟢 2.2 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟠 86
Accessibility 🟢 97
Best Practices 🟠 83
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🟠 4.0 s
Total Blocking Time 🟢 0 ms
Cumulative Layout Shift 🟢 0.006
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 76
Accessibility 🟢 97
Best Practices 🟠 83
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🔴 3.1 s
Largest Contentful Paint 🔴 5.0 s
Total Blocking Time 🟢 0 ms
Cumulative Layout Shift 🟢 0.001
Speed Index 🟢 3.1 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/profile/:id

Performance Metrics

Category Score
Performance 🟠 80
Accessibility 🟢 97
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.8 s
Largest Contentful Paint 🔴 4.4 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 2.8 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

ruehan
ruehan previously approved these changes Dec 6, 2024
@shlee9999 shlee9999 enabled auto-merge December 6, 2024 01:51
saseungmin
saseungmin previously approved these changes Dec 6, 2024
Copy link

@saseungmin saseungmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

src/hooks/useObserver.tsx Show resolved Hide resolved
@shlee9999 shlee9999 requested a review from ruehan December 6, 2024 05:07
@shlee9999 shlee9999 merged commit 043a6e3 into develop Dec 6, 2024
1 check passed
@github-actions github-actions bot deleted the 38-feature/notification-modal-data-binding branch December 14, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 알림 모달 데이터 바인딩
4 participants