Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings.json #120

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update settings.json #120

merged 1 commit into from
Dec 4, 2024

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Dec 4, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #109

settings.json에 필요 없는 내용이 포함되어 지웠습니다. (주석 색이 노란색으로 바뀌는 설정)

🖼️ Screenshots

Copy link

github-actions bot commented Dec 4, 2024

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 85
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.0 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 30 ms
Cumulative Layout Shift 🟢 0.004
Speed Index 🟢 2.0 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 85
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.001
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟠 86
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.6 s
Largest Contentful Paint 🟠 3.7 s
Total Blocking Time 🟢 0 ms
Cumulative Layout Shift 🟢 0.004
Speed Index 🟢 2.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 81
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.0 s
Largest Contentful Paint 🔴 4.8 s
Total Blocking Time 🟢 40 ms
Cumulative Layout Shift 🟢 0.001
Speed Index 🟢 2.0 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 merged commit be3a953 into develop Dec 4, 2024
2 checks passed
@github-actions github-actions bot deleted the 109-feature/settings-for-api branch December 12, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants