Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 리뷰 조회 리팩토링 #350

Merged
merged 14 commits into from
Feb 4, 2025
Merged

[REFACTOR] 리뷰 조회 리팩토링 #350

merged 14 commits into from
Feb 4, 2025

Conversation

leebs0521
Copy link
Collaborator

@leebs0521 leebs0521 commented Feb 4, 2025 •
edited
Loading

resolved :

📌 과제 설명

리뷰 조회 리팩토링

👩‍💻 요구 사항과 구현 내용

  • 리뷰 상세 조회시 모집글 아이디 필드 추가
  • 기존 리뷰 조회시 봉사자 닉네임 관련 리팩토링
  • 로그인한 봉사자, 기관 리뷰 리스트 조회 API 추가
    • 마이페이지에서 아마 봉사자랑 기관 아이디를 추출 못해서 API 엔드포인트 추가해놨습니다.

✅ PR 포인트 & 궁금한 점

@leebs0521 leebs0521 self-assigned this Feb 4, 2025
@leebs0521 leebs0521 linked an issue Feb 4, 2025 that may be closed by this pull request
[REFACTOR] 리뷰 조회 리팩토링 #349
Closed
2 tasks
m-a-king
m-a-king approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@m-a-king m-a-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

src/main/java/com/somemore/domains/review/controller/ReviewQueryApiController.java Show resolved Hide resolved
src/main/java/com/somemore/domains/review/service/ReviewQueryService.java Outdated Show resolved Hide resolved
ayoung-dev
ayoung-dev approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@ayoung-dev ayoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@leebs0521
refactor(review): 리뷰 상세 조회시, 모집글 아이디 응답 필드 추가
2e3d8e2
@leebs0521
test(review): 리뷰 상세 조회시, 모집글 아이디 응답 필드 추가 테스트
50f28d5
@leebs0521
refactor(review): 기존 봉사자 -> 새로운 봉사자 조회 리팩토링
c55092c
@leebs0521
test(review): 기존 봉사자 -> 새로운 봉사자 조회 리팩토링 테스트
576124f
@leebs0521
refactor(review): 봉사자 테이블 변경에 따른 리뷰 조회 리팩토링
927f2ae
@leebs0521
test(review): 봉사자 테이블 변경에 따른 리뷰 조회 리팩토링 테스트
5cb6256
@leebs0521
refactor: sonarqube 이슈 해결
b3dafb5
@leebs0521
refactor: sonarqube 이슈 해결
dbf6e51
@leebs0521
refactor(review): 기존 Center -> NewCenter 변경
8b613d7
@leebs0521
test(review): 기존 Center -> NewCenter 변경 테스트
186e14b
@leebs0521
feat(review): 기관 혹은 봉사자 자신의 리뷰 리스트 조회 API 기능 추가
09f386b
@leebs0521
chore(review): 불필요한 import 제거
e38ab71
@leebs0521
fix(review): 오타 해결 updateAt -> updatedAt
0094a42
@leebs0521
refactor(review): 가독성 있게 변경
aff6f59
@leebs0521 leebs0521 force-pushed the refactor/349-modify-review-query branch from 4ca4a50 to aff6f59 Compare February 4, 2025 08:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@leebs0521 leebs0521 merged commit beaa7ad into main Feb 4, 2025
3 checks passed
@leebs0521 leebs0521 deleted the refactor/349-modify-review-query branch February 4, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-a-king m-a-king m-a-king approved these changes

@ayoung-dev ayoung-dev ayoung-dev approved these changes

@7zrv 7zrv Awaiting requested review from 7zrv

Assignees

@leebs0521 leebs0521

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 리뷰 조회 리팩토링
3 participants
@leebs0521 @ayoung-dev @m-a-king