Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 봉사 지원 조회 관련 리팩토링 #337

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

leebs0521
Copy link
Collaborator

@leebs0521 leebs0521 commented Jan 24, 2025

resolved :

📌 과제 설명

봉사 지원 조회 관련 리팩토링

👩‍💻 요구 사항과 구현 내용

  • 봉사 지원 조회에 필요한 봉사자 / 유저 조회 기능 추가
  • 위 수정사항에 따른 봉사 지원 조회 리팩토링
  • 리팩토링후 불필요한 기능 제거

✅ PR 포인트 & 궁금한 점

이쪽부분 자세히 봐주시면 감사하겠습니다.

  • NewVolunteerQueryUseCase & UserQueryService 에서 가져오고 Map하는부분?

@leebs0521 leebs0521 self-assigned this Jan 24, 2025
@leebs0521 leebs0521 linked an issue Jan 24, 2025 that may be closed by this pull request
3 tasks
@leebs0521 leebs0521 changed the title Refactor/335 modify volunteer apply query [REFACTOR] 봉사 지원 조회 관련 리팩토링 Jan 24, 2025
Copy link
Collaborator

@ayoung-dev ayoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

Copy link
Collaborator

@m-a-king m-a-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

파사드 서비스 잘 봤습니다~

사소한 피드백을 드리자면, Map 형태의 변수명에 Map이라는 표현만 사용되다 보니, 해당 자료가 무엇을 의미하는지 조금 이해하기 어려운 부분이 있었던 것 같습니다.

만약 AToB나 AByB 같은 네이밍 패턴을 활용한다면, 자료의 의도를 더 명확히 드러낼 수 있을 것 같아요!

@leebs0521 leebs0521 force-pushed the refactor/335-modify-volunteer-apply-query branch from ce7df37 to bd31c77 Compare January 31, 2025 05:36
@leebs0521 leebs0521 force-pushed the refactor/335-modify-volunteer-apply-query branch from bd31c77 to f2c9506 Compare January 31, 2025 05:50
@leebs0521 leebs0521 merged commit 5b50d7d into main Jan 31, 2025
3 checks passed
@leebs0521 leebs0521 deleted the refactor/335-modify-volunteer-apply-query branch January 31, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 봉사 지원 조회 관련 리팩토링
4 participants