Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 새로운 테이블에 따른 봉사지원 리팩토링 #322

Merged
merged 7 commits into from
Jan 22, 2025
Merged

[REFACTOR] 새로운 테이블에 따른 봉사지원 리팩토링 #322

merged 7 commits into from
Jan 22, 2025

Conversation

leebs0521
Copy link
Collaborator

@leebs0521 leebs0521 commented Jan 22, 2025 •
edited
Loading

resolved :

📌 과제 설명

새로운 테이블에 따른 봉사지원 리팩토링(조회 부분 제외)

👩‍💻 요구 사항과 구현 내용

  • @currentuser -> @RoleId 변경
  • 봉사 지원 정산부분 NEWVolunteer 추가
  • 조회 제외부분 Volunteer -> NewVolunteer 변경

✅ PR 포인트 & 궁금한 점

  • 봉사 지원 조회는 어지럽네요... 일단 커맨드쪽 부분만..

@leebs0521 leebs0521 self-assigned this Jan 22, 2025
@leebs0521 leebs0521 linked an issue Jan 22, 2025 that may be closed by this pull request
[REFACTOR] 새로운 테이블에 따른 봉사지원 리팩토링 #318
Closed
3 tasks
m-a-king
m-a-king approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@m-a-king m-a-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

ayoung-dev
ayoung-dev approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@ayoung-dev ayoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@7zrv 7zrv closed this Jan 22, 2025
@7zrv 7zrv reopened this Jan 22, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@7zrv 7zrv merged commit 3b7666f into main Jan 22, 2025
3 of 4 checks passed
@7zrv 7zrv deleted the refactor/318-refactor-volunteer-apply branch January 22, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoung-dev ayoung-dev ayoung-dev approved these changes

@7zrv 7zrv 7zrv approved these changes

@m-a-king m-a-king m-a-king approved these changes

Assignees

@leebs0521 leebs0521

Labels
Refactor 범수
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 새로운 테이블에 따른 봉사지원 리팩토링
4 participants
@leebs0521 @ayoung-dev @7zrv @m-a-king