From cb679a7d216eeaf91523e8474d507b37d80017be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=EC=A1=B0=EC=9E=AC=EC=A4=91?=
 <126754298+m-a-king@users.noreply.github.com>
Date: Wed, 22 Jan 2025 22:53:00 +0900
Subject: [PATCH] =?UTF-8?q?refactor(service):=20=EB=B6=88=ED=95=84?=
 =?UTF-8?q?=EC=9A=94=ED=95=9C=20=EC=BD=94=EB=93=9C=20=EC=A0=9C=EA=B1=B0=20?=
 =?UTF-8?q?=EB=B0=8F=20=EB=B3=80=EC=88=98=EB=AA=85=20=EB=B3=80=EA=B2=BD?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- `findVolunteer`와 `findVolunteerDetail` 메서드 제거
  - 사용되지 않는 메서드로 판단하여 삭제
- `NEWVolunteerRepository` 변수명을 `volunteerRepository`로 변경
  - 가독성 및 네이밍 일관성 강화
---
 .../volunteer/service/VolunteerQueryService.java     | 12 ------------
 .../service/RegisterNEWVolunteerService.java         |  4 ++--
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/src/main/java/com/somemore/domains/volunteer/service/VolunteerQueryService.java b/src/main/java/com/somemore/domains/volunteer/service/VolunteerQueryService.java
index 182a5b6a..607d2c75 100644
--- a/src/main/java/com/somemore/domains/volunteer/service/VolunteerQueryService.java
+++ b/src/main/java/com/somemore/domains/volunteer/service/VolunteerQueryService.java
@@ -1,7 +1,6 @@
 package com.somemore.domains.volunteer.service;
 
 import com.somemore.domains.volunteer.domain.Volunteer;
-import com.somemore.domains.volunteer.domain.VolunteerDetail;
 import com.somemore.domains.volunteer.dto.response.VolunteerRankingResponseDto;
 import com.somemore.domains.volunteer.repository.VolunteerDetailRepository;
 import com.somemore.domains.volunteer.repository.VolunteerRepository;
@@ -70,15 +69,4 @@ public void validateVolunteerExists(UUID volunteerId) {
             throw new BadRequestException(NOT_EXISTS_VOLUNTEER.getMessage());
         }
     }
-
-    private Volunteer findVolunteer(UUID volunteerId) {
-        return volunteerRepository.findById(volunteerId)
-                .orElseThrow(() -> new BadRequestException(NOT_EXISTS_VOLUNTEER));
-    }
-
-    private VolunteerDetail findVolunteerDetail(UUID volunteerId) {
-        return volunteerDetailRepository.findByVolunteerId(volunteerId)
-                .orElseThrow(() -> new BadRequestException(NOT_EXISTS_VOLUNTEER));
-    }
-
 }
diff --git a/src/main/java/com/somemore/volunteer/service/RegisterNEWVolunteerService.java b/src/main/java/com/somemore/volunteer/service/RegisterNEWVolunteerService.java
index 86d7e753..abbefc83 100644
--- a/src/main/java/com/somemore/volunteer/service/RegisterNEWVolunteerService.java
+++ b/src/main/java/com/somemore/volunteer/service/RegisterNEWVolunteerService.java
@@ -14,12 +14,12 @@
 @Transactional
 public class RegisterNEWVolunteerService implements NEWRegisterVolunteerUseCase {
 
-    private final NEWVolunteerRepository NEWVolunteerRepository;
+    private final NEWVolunteerRepository volunteerRepository;
 
     @Override
     public void register(UUID userId) {
         NEWVolunteer volunteer = NEWVolunteer.createDefault(userId);
 
-        NEWVolunteerRepository.save(volunteer);
+        volunteerRepository.save(volunteer);
     }
 }