Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate heal location constants automatically #685

Open
wants to merge 1 commit into
base: porymap-6
Choose a base branch
from

Conversation

GriffinRichards
Copy link
Member

  • Generates include/constants/heal_locations.h using the heal location data, so users don't need to manage them at all.
  • Reverses course a bit from Move heal locations data to their associated map.json #673 by moving heal location data from the respective map.json files back to a single separate file. There was a few reasons for this:
    • Getting the correct value order for heal location constants would otherwise be much messier, probably requiring something like connection_include_order.
    • After Generate local IDs from map.json files #675 the value for respawn_npc can be updated automatically, so it's less important to have that in map.json.
    • It should be faster. Editing heal location data will no longer require processing every map.json file.
    • The inja template should be much simpler to understand at a glance than the C++ code that was in mapjson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant